netdev - Re: [PATCH v2] net: sh-eth: Add flag to determine the type of TSU register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51891350.9060700@cogentembedded.com>
Date:	Tue, 07 May 2013 18:44:32 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
CC:	netdev@...r.kernel.org, yoshihiro.shimoda.uh@...esas.com
Subject: Re: [PATCH v2] net: sh-eth: Add flag to determine the type of TSU
 register

Hello.

    You shouldn't have posted this patch (and the subsequent series) 
during the merge window, as David will probably tell you.

On 07-05-2013 9:08, Nobuhiro Iwamatsu wrote:

> Some sh-eth devices may have two ether devices inside.

    You probably meant to say: "some SoCs may have two Ether devices 
inside".

> And the function of TSU is accessed from each ether device.
> In this case, sh-eth need to remap address using devm_ioremap(),
> without using devm_ioremap_resource().

    You could use devm_ioremap_resource() for the 1st Ether instance, 
and devm_ioremap() for the 2nd, couldn't you?

> tsu_shared_reg of sh_eth_cpu_data is used for this control.

> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html