netdev - Re: [PATCH v2] net: sh-eth: Add flag to determine the type of TSU register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51AD13AD.9090501@cogentembedded.com>
Date:	Tue, 04 Jun 2013 02:07:41 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
CC:	netdev@...r.kernel.org, yoshihiro.shimoda.uh@...esas.com
Subject: Re: [PATCH v2] net: sh-eth: Add flag to determine the type of TSU
 register

Hello.

On 05/07/2013 09:08 AM, Nobuhiro Iwamatsu wrote:

> Some sh-eth devices may have two ether devices inside.
> And the function of TSU is accessed from each ether device.
> In this case, sh-eth need to remap address using devm_ioremap(),
> without using devm_ioremap_resource().
> tsu_shared_reg of sh_eth_cpu_data is used for this control.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
[...]

> @@ -2750,7 +2754,12 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
>   			ret = -ENODEV;
>   			goto out_release;
>   		}

     This patch is not good anymore since in the meanwhile the above 
check got removed.
Iwamatsu-san, are you going to respin this patch and the next series of 
9 patches any time
soon. I need them to base my work on.

> -		mdp->tsu_addr = devm_ioremap_resource(&pdev->dev, rtsu);
> +
> +		if (mdp->cd->tsu_shared_reg)
> +			mdp->tsu_addr = devm_ioremap(&pdev->dev, rtsu->start,
> +					resource_size(rtsu));
> +		else
> +			mdp->tsu_addr = devm_ioremap_resource(&pdev->dev, rtsu);
>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html