lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 04 Jun 2013 21:19:48 +0400 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com> CC: netdev@...r.kernel.org, yoshihiro.shimoda.uh@...esas.com Subject: Re: [PATCH v2] net: sh-eth: Add flag to determine the type of TSU register Hello. On 05/07/2013 06:44 PM, I wrote: > You shouldn't have posted this patch (and the subsequent series) > during the merge window, as David will probably tell you. > > On 07-05-2013 9:08, Nobuhiro Iwamatsu wrote: > >> Some sh-eth devices may have two ether devices inside. > > You probably meant to say: "some SoCs may have two Ether devices > inside". > >> And the function of TSU is accessed from each ether device. >> In this case, sh-eth need to remap address using devm_ioremap(), >> without using devm_ioremap_resource(). > > You could use devm_ioremap_resource() for the 1st Ether instance, > and devm_ioremap() for the 2nd, couldn't you? Wait, you can't have the same resource on both platform devices, that's a resource conflict. > >> tsu_shared_reg of sh_eth_cpu_data is used for this control. > >> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com> > WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists