netdev - RE: [PATCH v2 4/4] net: phy: realtek: cleanup code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <017801ce4f84$5d423320$17c69960$@lge.com>
Date:	Mon, 13 May 2013 11:48:35 +0900
From:	"Jongsung Kim" <neidhard.kim@....com>
To:	"'Sergei Shtylyov'" <sergei.shtylyov@...entembedded.com>
Cc:	<davem@...emloft.net>, <peppe.cavallaro@...com>,
	<chohnstaedt@...ominate.com>, <timur@...escale.com>,
	<heiko.carstens@...ibm.com>, <schwidefsky@...ibm.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 4/4] net: phy: realtek: cleanup code

Sergei Shtylyov <sergei.shtylyov@...entembedded.com> :
>> -		.suspend	= genphy_suspend,
>> -		.resume		= genphy_resume,
>> +		.suspend	= &genphy_suspend,
>> +		.resume		= &genphy_resume,
>
>    Contrariwise, you should have dropped & from the other functions. 
>It's completely superfluous.
>

Agreed. Thank you  for your comment, Sergei.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html