netdev - Re: [PATCH] net/802/mrp: fix lockdep splat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1368495034.32106.1.camel@edumazet-glaptop>
Date:	Mon, 13 May 2013 18:30:34 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Cong Wang <amwang@...hat.com>
Cc:	Denys Fedoryshchenko <denys@...p.net.lb>,
	David Ward <david.ward@...mit.edu>,
	hayeswang <hayeswang@...ltek.com>,
	Francois Romieu <romieu@...zoreil.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] net/802/mrp: fix lockdep splat

On Tue, 2013-05-14 at 09:12 +0800, Cong Wang wrote:
> On Mon, 2013-05-13 at 05:24 -0700, Eric Dumazet wrote:
> >         del_timer_sync(&app->join_timer);
> >  
> > -       spin_lock(&app->lock);
> > +       spin_lock_bh(&app->lock); 
> 
> But we just have removed the join timer before taking this spin lock, so
> it is not possible to race with timer, but we still have race condition
> with mrp_rcv() which is called in BH context too. However, this is not
> what Denys reported, so I have no idea on this.
> 

Thats a lockdep splat.

lockdep cannot know join timer wont fire again.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html