netdev - Re: [PATCH] net/802/mrp: fix lockdep splat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130514.120754.1745967383330029903.davem@davemloft.net>
Date:	Tue, 14 May 2013 12:07:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	denys@...p.net.lb
Cc:	eric.dumazet@...il.com, amwang@...hat.com, david.ward@...mit.edu,
	hayeswang@...ltek.com, romieu@...zoreil.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net/802/mrp: fix lockdep splat

From: Denys Fedoryshchenko <denys@...p.net.lb>
Date: Mon, 13 May 2013 15:53:30 +0300

> Thank you for superfast answer :)
> It is changed a bit, but not disappeared. Relevant part from new
> dmesg:

Can you double check that you really had Eric's patch applied?
lockdep appears to be complaining about the same thing in your
log dump, as if the patch was not really applied.

It's saying that app->lock can be taken from the join timer in
softirq, but mrp_uninit_applicant() takes it without disabling
softirqs.

Eric's patch explicitly fixes this, by making sure that spin_lock_bh()
is used there.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html