| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20130514.130307.629850895919092156.davem@davemloft.net> Date: Tue, 14 May 2013 13:03:07 -0700 (PDT) From: David Miller <davem@...emloft.net> To: eric.dumazet@...il.com Cc: denys@...p.net.lb, amwang@...hat.com, david.ward@...mit.edu, hayeswang@...ltek.com, romieu@...zoreil.com, netdev@...r.kernel.org Subject: Re: [PATCH] net/802/mrp: fix lockdep splat From: Eric Dumazet <eric.dumazet@...il.com> Date: Tue, 14 May 2013 12:40:01 -0700 > On Tue, 2013-05-14 at 12:21 -0700, Eric Dumazet wrote: >> On Tue, 2013-05-14 at 12:07 -0700, David Miller wrote: >> >> > Can you double check that you really had Eric's patch applied? >> > lockdep appears to be complaining about the same thing in your >> > log dump, as if the patch was not really applied. >> > >> > It's saying that app->lock can be taken from the join timer in >> > softirq, but mrp_uninit_applicant() takes it without disabling >> > softirqs. >> > >> > Eric's patch explicitly fixes this, by making sure that spin_lock_bh() >> > is used there. >> >> I am going to test this myself, it seems quite simple. >> I'll add a Tested-by: tag once done. > > I definitely could trigger the bug easily without my patch : ... > And with the patch, there is no lockdep splat anymore. > > Tested-by: Eric Dumazet <edumazet@...gle.com> Applied, thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists