netdev - RE: [PATCH v2 net 2/2] tg3: Fix data corruption on 5725 with TSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 May 2013 09:56:25 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Michael Chan" <mchan@...adcom.com>
Cc:	"Nithin Nayak Sujir" <nsujir@...adcom.com>,
	"Eric Dumazet" <eric.dumazet@...il.com>, <davem@...emloft.net>,
	<netdev@...r.kernel.org>, <stable@...r.kernel.org>
Subject: RE: [PATCH v2 net 2/2] tg3: Fix data corruption on 5725 with TSO

> > If the 'fix' is to relocate the skb you are doomed to lose regardless
> > of the check - unless you are willing to reallocate a lot of times,
> > and without freeing the old skb.
> > I'd assumed the 'fix' was to disable the relevant offload.
> 
> We relocate once and then drop the packet if we encounter additional
> errors, including OOM, DMA mapping error, 4G boundary, etc.  The new
> linear skb should not hit the 4G boundary again.  The room between the
> end of this current buffer and 4G isn't big enough for the new linear
> skb.

The first skb might be just below the 4G boundary and the
second just below the 8G one.

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html