netdev - Re: [PATCH 3/5] drivers: net: usb: rtl8150: bug fixing and cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130518210958.GB26590@electric-eye.fr.zoreil.com>
Date:	Sat, 18 May 2013 23:09:58 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Petko Manolov <petkan@...leusys.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] drivers: net: usb: rtl8150: bug fixing and cleanup

Petko Manolov <petkan@...leusys.com> :
[...]
> diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> index 7d1897b..fd4bc2a 100644
> --- a/drivers/net/usb/rtl8150.c
> +++ b/drivers/net/usb/rtl8150.c
[...]
>  static void rx_fixup(unsigned long data)
>  {
>  	struct rtl8150 *dev = (struct rtl8150 *)data;
>  	struct sk_buff *skb;
>  	int status;
>  
> -	spin_lock_irq(&dev->rx_pool_lock);
> -	fill_skb_pool(dev);
> -	spin_unlock_irq(&dev->rx_pool_lock);
>  	if (test_bit(RX_URB_FAIL, &dev->flags))
>  		if (dev->rx_skb)
>  			goto try_again;
> -	spin_lock_irq(&dev->rx_pool_lock);
> -	skb = pull_skb(dev);
> -	spin_unlock_irq(&dev->rx_pool_lock);
> +	skb = __netdev_alloc_skb_ip_align(dev->netdev, RTL8150_MTU, GFP_ATOMIC);

You can use plain netdev_alloc_skb_ip_align.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html