netdev - Re: [PATCH 3/5] drivers: net: usb: rtl8150: bug fixing and cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 19 May 2013 11:48:13 +0300 (EEST)
From:	Petko Manolov <petkan@...leusys.com>
To:	Francois Romieu <romieu@...zoreil.com>
cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] drivers: net: usb: rtl8150: bug fixing and cleanup

On Sat, 18 May 2013, Francois Romieu wrote:

> Petko Manolov <petkan@...leusys.com> :
> [...]
> > diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> > index 7d1897b..fd4bc2a 100644
> > --- a/drivers/net/usb/rtl8150.c
> > +++ b/drivers/net/usb/rtl8150.c
> [...]
> >  static void rx_fixup(unsigned long data)
> >  {
> >  	struct rtl8150 *dev = (struct rtl8150 *)data;
> >  	struct sk_buff *skb;
> >  	int status;
> >  
> > -	spin_lock_irq(&dev->rx_pool_lock);
> > -	fill_skb_pool(dev);
> > -	spin_unlock_irq(&dev->rx_pool_lock);
> >  	if (test_bit(RX_URB_FAIL, &dev->flags))
> >  		if (dev->rx_skb)
> >  			goto try_again;
> > -	spin_lock_irq(&dev->rx_pool_lock);
> > -	skb = pull_skb(dev);
> > -	spin_unlock_irq(&dev->rx_pool_lock);
> > +	skb = __netdev_alloc_skb_ip_align(dev->netdev, RTL8150_MTU, GFP_ATOMIC);
> 
> You can use plain netdev_alloc_skb_ip_align.

Yep, except for the call in rtl8150_open() (where GFP_KERNEL is more 
appropriate) i should have used the plain version.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html