| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.DEB.2.02.1305191136360.4537@fry.nucleusys.com> Date: Sun, 19 May 2013 11:42:06 +0300 (EEST) From: Petko Manolov <petkan@...leusys.com> To: Francois Romieu <romieu@...zoreil.com> cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/5] drivers: net: usb: rtl8150: bug fixing and cleanup On Sat, 18 May 2013, Francois Romieu wrote: > Petko Manolov <petkan@...leusys.com> : > > From: Petko Manolov <petkan@...leusys.com> > > > > Moving constant and structure definitions out of rtl8150.c; > > What's the point ? The general logic of having .h files applies. > [...] > > --- > > drivers/net/usb/rtl8150.c | 121 +---------------------------------- > > 1 file changed, 2 insertions(+), 119 deletions(-) > > > > diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c > > index a491d3a..7d1897b 100644 > > --- a/drivers/net/usb/rtl8150.c > > +++ b/drivers/net/usb/rtl8150.c > > @@ -17,132 +17,15 @@ > > #include <linux/usb.h> > > #include <asm/uaccess.h> > > > > +#include "rtl8150.h" > > It won't compile. You shouldn't do that. It does compile. Both inside and outside of the tree. If the proper place for rtl8150.h is somewhere in include/linux/... then it is different matter. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists