netdev - Re: [PATCH 1/5] drivers: net: usb: rtl8150: bug fixing and cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130519190116.GA4019@electric-eye.fr.zoreil.com>
Date:	Sun, 19 May 2013 21:01:16 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Petko Manolov <petkan@...leusys.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] drivers: net: usb: rtl8150: bug fixing and cleanup

Petko Manolov <petkan@...leusys.com> :
> On Sat, 18 May 2013, Francois Romieu wrote:
> > > From: Petko Manolov <petkan@...leusys.com>
[...]
> > > Moving constant and structure definitions out of rtl8150.c;
> > 
> > What's the point ?
> 
> The general logic of having .h files applies.

Which one ?
- share it through the kernel or with userspace
- personal choice .c split

I don't mind the later even if it does not exactly apply to a
WIP driver. I'd still avoid future copycat followers though.

[...]
> > >  drivers/net/usb/rtl8150.c |  121 +----------------------------------
> > >  1 file changed, 2 insertions(+), 119 deletions(-)
> > > 
> > > diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> > > index a491d3a..7d1897b 100644
> > > --- a/drivers/net/usb/rtl8150.c
> > > +++ b/drivers/net/usb/rtl8150.c
> > > @@ -17,132 +17,15 @@
> > >  #include <linux/usb.h>
> > >  #include <asm/uaccess.h>
> > >  
> > > +#include "rtl8150.h"
> > 
> > It won't compile. You shouldn't do that.
> 
> It does compile.  Both inside and outside of the tree.

The rtl8150.h file is created in patch #2. This is patch #1.

So...

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html