netdev - Re: [PATCH v2 net 1/1] r8169: fix offloaded tx checksum for small packets.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130520.000149.840626794135761237.davem@davemloft.net>
Date:	Mon, 20 May 2013 00:01:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	romieu@...zoreil.com
Cc:	netdev@...r.kernel.org, hayeswang@...ltek.com,
	stefan.bader@...onical.com, holger.hoffstaette@...glemail.com,
	sergei.shtylyov@...entembedded.com, ben@...adent.org.uk
Subject: Re: [PATCH v2 net 1/1] r8169: fix offloaded tx checksum for small
 packets.

From: Francois Romieu <romieu@...zoreil.com>
Date: Sat, 18 May 2013 13:24:46 +0200

> 8168evl offloaded checksums are wrong since commit
> e5195c1f31f399289347e043d6abf3ffa80f0005 ("r8169: fix 8168evl frame padding.")
> pads small packets to 60 bytes (without ethernet checksum). Typical symptoms
> appear as UDP checksums which are wrong by the count of added bytes.
> 
> It isn't worth compensating. Let the driver checksum.
> 
> Due to the skb length changes, TSO code is moved before the Tx descriptor gets
> written.
> 
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> ---
> 
>  I reworked some code since v1 to avoid wtf effects in the future. Holger's
>  Tested-by is thus not included. While I trust my testing, it would be nice
>  to wait for his ack as well.
> 
>  This is obviously stuff for -stable.

Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html