netdev - Re: [PATCH v2 net 1/1] r8169: fix offloaded tx checksum for small packets.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51B5B48A.5040807@googlemail.com>
Date:	Mon, 10 Jun 2013 13:12:10 +0200
From:	Holger Hoffstätte 
	<holger.hoffstaette@...glemail.com>
To:	Francois Romieu <romieu@...zoreil.com>
CC:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Hayes Wang <hayeswang@...ltek.com>,
	Stefan Bader <stefan.bader@...onical.com>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Ben Hutchings <ben@...adent.org.uk>
Subject: Re: [PATCH v2 net 1/1] r8169: fix offloaded tx checksum for small
 packets.

On 18.05.2013 16:42, Holger Hoffstätte wrote:
> On 18.05.2013 13:24, Francois Romieu wrote:
>> 8168evl offloaded checksums are wrong since commit
>> e5195c1f31f399289347e043d6abf3ffa80f0005 ("r8169: fix 8168evl frame padding.")
>> pads small packets to 60 bytes (without ethernet checksum). Typical symptoms
>> appear as UDP checksums which are wrong by the count of added bytes.
>>
>> It isn't worth compensating. Let the driver checksum.
>>
>> Due to the skb length changes, TSO code is moved before the Tx descriptor gets
>> written.
>>
>> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> 
> Tested again, still working for me.
> 
> Tested-by: Holger Hoffstätte <holger.hoffstaette@...glemail.com>

ping:

As far as I can tell this patch is still not in -stable 3.9.5 or queued
up for the next iteration.

Commit in Linus' tree is b423e9ae49d78ea3f53b131c8d5a6087aed16fd6

thanks :)

-h

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html