netdev - Re: [PATCH] qlge: add missing free_netdev() on error in qlge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BECD8E8A1B550B48A1BF97C13991F60E32A4FE@avmb2.qlogic.org>
Date:	Thu, 23 May 2013 14:40:46 +0000
From:	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
To:	Wei Yongjun <weiyj.lk@...il.com>,
	Shahed Shaikh <shahed.shaikh@...gic.com>,
	Ron Mercer <ron.mercer@...gic.com>
CC:	"yongjun_wei@...ndmicro.com.cn" <yongjun_wei@...ndmicro.com.cn>,
	Dept-Eng Linux Driver <Linux-Driver@...gic.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] qlge: add missing free_netdev() on error in qlge_probe()

On 5/23/13 2:09 AM, "Wei Yongjun" <weiyj.lk@...il.com> wrote:

>From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
>Add the missing free_netdev() before return from function
>qlge_probe() in the error handling case.
>
>Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>---
> drivers/net/ethernet/qlogic/qlge/qlge_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_main.c
>b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
>index e04d471..2553cf4 100644
>--- a/drivers/net/ethernet/qlogic/qlge/qlge_main.c
>+++ b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
>@@ -4717,6 +4717,7 @@ static int qlge_probe(struct pci_dev *pdev,
> 		dev_err(&pdev->dev, "net device registration failed.\n");
> 		ql_release_all(pdev);
> 		pci_disable_device(pdev);
>+		free_netdev(ndev);
> 		return err;
> 	}
> 	/* Start up the timer to trigger EEH if

Thanks!

Acked-by: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html