netdev - RE: [PATCH net, 1/2] hyperv: Fix a kernel warning from netvsc_linkstatus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed50df23ce9a4fb785faa0082ff79c95@DFM-TK5MBX15-06.exchange.corp.microsoft.com>
Date:	Thu, 23 May 2013 14:51:57 +0000
From:	Haiyang Zhang <haiyangz@...rosoft.com>
To:	Richard Genoud <richard.genoud@...il.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"jasowang@...hat.com" <jasowang@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"stable (stable@...nel.org)" <stable@...nel.org>
Subject: RE: [PATCH net, 1/2] hyperv: Fix a kernel warning from
 netvsc_linkstatus_callback()



> -----Original Message-----
> From: Richard Genoud [mailto:richard.genoud@...il.com]
> Sent: Thursday, May 23, 2013 4:44 AM
> To: Haiyang Zhang
> Cc: davem@...emloft.net; netdev@...r.kernel.org; olaf@...fle.de;
> jasowang@...hat.com; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org
> Subject: Re: [PATCH net, 1/2] hyperv: Fix a kernel warning from
> netvsc_linkstatus_callback()
> 
> 2013/4/5 Haiyang Zhang <haiyangz@...rosoft.com>:
> > The warning about local_bh_enable inside IRQ happens when
> > disconnecting a virtual NIC.
> >
> > The reason for the warning is -- netif_tx_disable() is called when the
> > NIC is disconnected. And it's called within irq context.
> > netif_tx_disable() calls
> > local_bh_enable() which displays warning if in irq.
> >
> > The fix is to remove the unnecessary netif_tx_disable & wake_queue()
> > in the netvsc_linkstatus_callback().
> >
> > Reported-by: Richard Genoud <richard.genoud@...il.com>
> > Tested-by: Long Li <longli@...rosoft.com>
> > Tested-by: Richard Genoud <richard.genoud@...il.com>
> > Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> > Reviewed-by: K. Y. Srinivasan <kys@...rosoft.com>
> >
> > ---
> >  drivers/net/hyperv/netvsc_drv.c |    2 --
> >  1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/hyperv/netvsc_drv.c
> > b/drivers/net/hyperv/netvsc_drv.c index 5f85205..8341b62 100644
> > --- a/drivers/net/hyperv/netvsc_drv.c
> > +++ b/drivers/net/hyperv/netvsc_drv.c
> > @@ -241,13 +241,11 @@ void netvsc_linkstatus_callback(struct hv_device
> > *device_obj,
> >
> >         if (status == 1) {
> >                 netif_carrier_on(net);
> > -               netif_wake_queue(net);
> >                 ndev_ctx = netdev_priv(net);
> >                 schedule_delayed_work(&ndev_ctx->dwork, 0);
> >                 schedule_delayed_work(&ndev_ctx->dwork,
> msecs_to_jiffies(20));
> >         } else {
> >                 netif_carrier_off(net);
> > -               netif_tx_disable(net);
> >         }
> >  }
> >
> > --
> > 1.7.4.1
> 
> This should also go to the stable tree, shouldn't it ?
> At least 3.8, 3.7 and 3.4 (the 3.2 version is different, and it's in staging. (at not
> used by distros anyway))

Cc: stable <stable@...nel.org>

I agree. Adding stable@...nel.org to Cc list.

Thanks,
- Haiyang