netdev - Re: [PATCH 6/7] sctp: Correct access to skb->{network,transport}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1369855872.1971.1.camel@bwh-desktop.uk.level5networks.com>
Date:	Wed, 29 May 2013 20:31:12 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Simon Horman <horms@...ge.net.au>
CC:	David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH 6/7] sctp: Correct access to
 skb->{network,transport}_header

On Wed, 2013-05-29 at 14:27 +0900, Simon Horman wrote:
> This corrects an regression introduced by "net: Use 16bits for *_headers
> fields of struct skbuff" when NET_SKBUFF_DATA_USES_OFFSET is not set.

So how about adding 'typedef u16 sk_buff_data_t;'?

> In
> that case sk_buff_data_t will be a pointer, however,
> skb->{network,transport}_header is now __u16.
> 
> Signed-off-by: Simon Horman <horms@...ge.net.au>
> ---
>  net/sctp/input.c |    2 +-
>  net/sctp/ipv6.c  |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sctp/input.c b/net/sctp/input.c
> index 4b2c831..e328fe8 100644
> --- a/net/sctp/input.c
> +++ b/net/sctp/input.c
> @@ -589,7 +589,7 @@ void sctp_v4_err(struct sk_buff *skb, __u32 info)
>  	struct sctp_association *asoc = NULL;
>  	struct sctp_transport *transport;
>  	struct inet_sock *inet;
> -	sk_buff_data_t saveip, savesctp;
> +	__be16 saveip, savesctp;
[...]

__be16??

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html