netdev - Re: [PATCH] ip_vs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1305292219170.1951@ja.ssi.bg>
Date:	Wed, 29 May 2013 22:31:19 +0300 (EEST)
From:	Julian Anastasov <ja@....bg>
To:	Jan Beulich <JBeulich@...e.com>
cc:	wensong@...ux-vs.org, horms@...ge.net.au, pablo@...filter.org,
	lvs-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] ip_vs_sh: fix build


	Hello,

On Wed, 29 May 2013, Jan Beulich wrote:

> kfree_rcu() requires offsetof(..., rcu_head) < 4096, which can get
> violated with a sufficiently high CONFIG_IP_VS_SH_TAB_BITS.
> 
> Signed-off-by: Jan Beulich <jbeulich@...e.com>
> 
> ---
>  net/netfilter/ipvs/ip_vs_sh.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- 3.10-rc3/net/netfilter/ipvs/ip_vs_sh.c
> +++ 3.10-rc3-ip_vs_sh-build/net/netfilter/ipvs/ip_vs_sh.c
> @@ -67,8 +67,8 @@ struct ip_vs_sh_bucket {
>  #define IP_VS_SH_TAB_MASK               (IP_VS_SH_TAB_SIZE - 1)
>  
>  struct ip_vs_sh_state {
> -	struct ip_vs_sh_bucket		buckets[IP_VS_SH_TAB_SIZE];
>  	struct rcu_head			rcu_head;
> +	struct ip_vs_sh_bucket		buckets[IP_VS_SH_TAB_SIZE];

	Your fix reminds me about the same problem
I noticed for LBLC (may be due to 10 bits) during development
but forgot to check the other schedulers. The same solution
is needed also for DH. OTOH, LBLC and LBLCR are correct.
Do you prefer to provide similar fix for ip_vs_dh.c or
I have to take care?

>  };
>  
>  /*

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html