netdev - Re: [PATCH net-next v3 1/2] vxlan: introduce vxlan_rdst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130529155642.391b50b3@nehalam.linuxnetplumber.net>
Date:	Wed, 29 May 2013 15:56:42 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Mike Rapoport <mike.rapoport@...ellosystems.com>
Cc:	netdev@...r.kernel.org, Thomas Graf <tgraf@...g.ch>
Subject: Re: [PATCH net-next v3 1/2] vxlan: introduce vxlan_rdst_append

On Wed, 29 May 2013 13:00:15 +0300
Mike Rapoport <mike.rapoport@...ellosystems.com> wrote:

> -/* Add/update destinations for multicast */
> -static int vxlan_fdb_append(struct vxlan_fdb *f,
> -			    __be32 ip, __be16 port, __u32 vni, __u32 ifindex)
> +static int vxlan_rdst_append(struct vxlan_rdst *rdst, __be32 ip, __be16 port,
> +			     __u32 vni, __u32 ifindex)
>  {
>  	struct vxlan_rdst *rd_prev, *rd;
>  
>  	rd_prev = NULL;
> -	for (rd = &f->remote; rd; rd = rd->remote_next) {
> +	for (rd = rdst; rd; rd = rd->remote_next) {

The remote destinations should be using one of our nice list macros.
And what about locking? or RCU?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html