netdev - Re: [PATCH net-next v3 1/2] vxlan: introduce vxlan_rdst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF1J0HOZv3m08qyJuStH-zKwF1H4vWVhnRE6anorfspGzuVKeQ@mail.gmail.com>
Date:	Thu, 30 May 2013 11:42:42 +0300
From:	Mike Rapoport <mike.rapoport@...ellosystems.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	netdev@...r.kernel.org, Thomas Graf <tgraf@...g.ch>
Subject: Re: [PATCH net-next v3 1/2] vxlan: introduce vxlan_rdst_append

On Thu, May 30, 2013 at 1:56 AM, Stephen Hemminger
<stephen@...workplumber.org> wrote:
> On Wed, 29 May 2013 13:00:15 +0300
> Mike Rapoport <mike.rapoport@...ellosystems.com> wrote:
>
>> -/* Add/update destinations for multicast */
>> -static int vxlan_fdb_append(struct vxlan_fdb *f,
>> -                         __be32 ip, __be16 port, __u32 vni, __u32 ifindex)
>> +static int vxlan_rdst_append(struct vxlan_rdst *rdst, __be32 ip, __be16 port,
>> +                          __u32 vni, __u32 ifindex)
>>  {
>>       struct vxlan_rdst *rd_prev, *rd;
>>
>>       rd_prev = NULL;
>> -     for (rd = &f->remote; rd; rd = rd->remote_next) {
>> +     for (rd = rdst; rd; rd = rd->remote_next) {
>
> The remote destinations should be using one of our nice list macros.

Can you explain why?
Current linked list implementation for multiple destinations in fdb
seems quite Ok and I've just reused it for default destinations
management...

> And what about locking? or RCU?

Oops, mu fault :)

--
Sincerely yours,
Mike.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html