netdev - Re: [PATCH 3/4 net-next] tcp: fix undo on partial ack in recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130530.180728.50725302633946582.davem@davemloft.net>
Date:	Thu, 30 May 2013 18:07:28 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ycheng@...gle.com
Cc:	ncardwell@...gle.com, edumazet@...gle.com, nanditad@...gle.com,
	aterzis@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH 3/4 net-next] tcp: fix undo on partial ack in recovery

From: Yuchung Cheng <ycheng@...gle.com>
Date: Wed, 29 May 2013 17:20:13 -0700

> Upon detecting spurious fast retransmit via timestamps during recovery,
> use PRR to clock out new data packet instead of retransmission. Once
> all retransmission are proven spurious, the sender then reverts the
> cwnd reduction and congestion state to open or disorder.
> 
> The current code does the opposite: it undoes cwnd as soon as any
> retransmission is spurious and continues to retransmit until all
> data are acked. This nullifies the point to undo the cwnd because
> the sender is still retransmistting spuriously. This patch fixes
> it. The undo_ssthresh argument of tcp_undo_cwnd_reductiuon() is no
> longer needed and is removed.
> 
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html