netdev - Re: [PATCH net-next 02/12] tipc: Add "max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130531092302.GA8131@eerihug-hybrid.ki.sw.ericsson.se>
Date:	Fri, 31 May 2013 11:23:02 +0200
From:	Erik Hugne <erik.hugne@...csson.com>
To:	David Miller <davem@...emloft.net>
CC:	paul.gortmaker@...driver.com, netdev@...r.kernel.org,
	jon.maloy@...csson.com, ying.xue@...driver.com
Subject: Re: [PATCH net-next 02/12] tipc: Add "max_ports" configuration
 parameter

On Fri, May 31, 2013 at 01:40:28AM -0700, David Miller wrote:
> We never shrink the hash tables once we've grown them.  That's a
> reasonable way to behave.

Very well.
Currently, the refs/portID's are built up of a random part, and an index
part. The index is obtained by masking against the table size.
If the table is allowed to grow, we must remove the random part from the 
portID. Otherwise we would index out a nonexistant or wrong port
from a received packet..

But removing the random part would be a violation of the protocol spec, and
potentially break interop between other implementations (like link selection..)

//E
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html