[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20130531.022628.1036824788160880030.davem@davemloft.net>
Date: Fri, 31 May 2013 02:26:28 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: erik.hugne@...csson.com
Cc: paul.gortmaker@...driver.com, netdev@...r.kernel.org,
jon.maloy@...csson.com, ying.xue@...driver.com
Subject: Re: [PATCH net-next 02/12] tipc: Add "max_ports" configuration
parameter
From: Erik Hugne <erik.hugne@...csson.com>
Date: Fri, 31 May 2013 11:23:02 +0200
> On Fri, May 31, 2013 at 01:40:28AM -0700, David Miller wrote:
>> We never shrink the hash tables once we've grown them. That's a
>> reasonable way to behave.
>
> Very well.
> Currently, the refs/portID's are built up of a random part, and an index
> part. The index is obtained by masking against the table size.
> If the table is allowed to grow, we must remove the random part from the
> portID. Otherwise we would index out a nonexistant or wrong port
> from a received packet..
>
> But removing the random part would be a violation of the protocol spec, and
> potentially break interop between other implementations (like link selection..)
We allocate ports randomly for IPV4/IPV6 sockets, you can just fine too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists