netdev - RE: [PATCH net-next] bnx2x: use XPS if possible for bnx2x_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 1 Jun 2013 11:27:40 +0000
From:	"Dmitry Kravkov" <dmitry@...adcom.com>
To:	"Eric Dumazet" <eric.dumazet@...il.com>,
	"David Miller" <davem@...emloft.net>
cc:	netdev <netdev@...r.kernel.org>,
	"govindarajulu.v" <govindarajulu90@...il.com>,
	"Havard Skinnemoen" <hskinnemoen@...gle.com>,
	"Eilon Greenstein" <eilong@...adcom.com>
Subject: RE: [PATCH net-next] bnx2x: use XPS if possible for
 bnx2x_select_queue instead of pure hash

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] On Behalf Of Eric Dumazet
> Sent: Saturday, June 01, 2013 3:33 AM
> To: David Miller
> Cc: netdev; govindarajulu.v; Havard Skinnemoen; Eilon Greenstein
> Subject: [PATCH net-next] bnx2x: use XPS if possible for bnx2x_select_queue instead of pure hash
> 
> From: Eric Dumazet <edumazet@...gle.com>
> 
> The bnx2x_select_queue() was using __skb_tx_hash() to select the
> transmit queue, totally ignoring XPS settings, while XPS can help
> performance quite significantly, so change the bnx2x_select_queue()
> to use __dev_pick_tx() instead which will use XPS if configured.
> 
> Based on patches from Ying Cai and Havard Skinnemoen
> 
> Reported-by: govindarajulu.v <govindarajulu90@...il.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Havard Skinnemoen <hskinnemoen@...gle.com>
> Cc: Ying Cai <ycai@...gle.com>
> Cc: Eilon Greenstein <eilong@...adcom.com>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> index c80f1d2..3651f6d 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> @@ -1829,7 +1829,7 @@ u16 bnx2x_select_queue(struct net_device *dev, struct sk_buff *skb)
>  	}
> 
>  	/* select a non-FCoE queue */
> -	return __skb_tx_hash(dev, skb, BNX2X_NUM_ETH_QUEUES(bp));
> +	return __netdev_pick_tx(dev, skb) % BNX2X_NUM_ETH_QUEUES(bp);
>  }
> 
>  void bnx2x_set_num_queues(struct bnx2x *bp)

Acked-by: Dmitry Kravkov <dmitry@...adcom.com>