netdev - Re: [PATCH net-next] bnx2x: use XPS if possible for bnx2x_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130601.193857.1132434060524891436.davem@davemloft.net>
Date:	Sat, 01 Jun 2013 19:38:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dmitry@...adcom.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	govindarajulu90@...il.com, hskinnemoen@...gle.com,
	eilong@...adcom.com
Subject: Re: [PATCH net-next] bnx2x: use XPS if possible for
 bnx2x_select_queue instead of pure hash

From: "Dmitry Kravkov" <dmitry@...adcom.com>
Date: Sat, 1 Jun 2013 11:27:40 +0000

>> The bnx2x_select_queue() was using __skb_tx_hash() to select the
>> transmit queue, totally ignoring XPS settings, while XPS can help
>> performance quite significantly, so change the bnx2x_select_queue()
>> to use __dev_pick_tx() instead which will use XPS if configured.
>> 
>> Based on patches from Ying Cai and Havard Skinnemoen
>> 
>> Reported-by: govindarajulu.v <govindarajulu90@...il.com>
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
 ...
> Acked-by: Dmitry Kravkov <dmitry@...adcom.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html