netdev - Re: [RFC] vxlan: convert remote list to list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF180D88FD.2197D607-ON85257B80.00649BFC-85257B80.00689768@us.ibm.com>
Date:	Tue, 4 Jun 2013 15:02:26 -0400
From:	David Stevens <dlstevens@...ibm.com>
To:	Mike Rapoport <mike.rapoport@...ellosystems.com>
Cc:	netdev@...r.kernel.org, netdev-owner@...r.kernel.org,
	Stephen Hemminger <stephen@...workplumber.org>,
	Thomas Graf <tgraf@...g.ch>
Subject: Re: [RFC] vxlan: convert remote list to list_rcu

netdev-owner@...r.kernel.org wrote on 06/04/2013 01:20:22 PM:

> From: Mike Rapoport <mike.rapoport@...ellosystems.com>

> If I've understood you right it would be something like this:
> 

All the tabs are removed in the code I got-- don't know if
it's your mailer or my reader....

> @@ -1025,13 +1027,10 @@ static netdev_tx_t vxlan_xmit_one(struct
> sk_buff *skb, struct net_device *dev,
>   vni = rdst->remote_vni;
>   dst = rdst->remote_ip;
> 
> - if (!dst) {
> - if (did_rsc) {
> - /* short-circuited back to local bridge */
> - vxlan_encap_bypass(skb, vxlan, vxlan);
> - return NETDEV_TX_OK;
> - }
> - goto drop;
> + if (did_rsc) {
> + /* short-circuited back to local bridge */
> + vxlan_encap_bypass(skb, vxlan, vxlan);
> + return NETDEV_TX_OK;
>   }

This isn't correct -- I led you into that one,
but the original code is what we'd need -- it isn't
"rdst NULL" this is checking, but really "dst == INADDR_ANY",
which is probably what it ought to be, instead of "0".
At any rate, the check there works and needs to stay;
dst == INADDR_ANY is a distinct case from rdst == NULL.

Also looks like you're missing a brace on the L2MISS check --
the miss and the drop are only if the all-zeroes lookup
fails.

But the general idea looks good. If you remove the 
is_zero_ether_addr() check in rtnl_fdb_add and rtnl_fdb_del,
then the existing fdb_add/fdb_append/fdb_del code code
would allow changes, including multiple destinations, to
the default destinations as well.

But there's more to it, too -- default_dst and all its references
would need to be replaced for joining groups and the netlink
part, and removed from vxlan_dev.

                                                        +-DLS

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html