netdev - Re: [PATCH] net_sched: htb: do not mix 1ns and 64ns time units

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130604.174439.327058035432515764.davem@davemloft.net>
Date:	Tue, 04 Jun 2013 17:44:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	brouer@...hat.com, stephen@...workplumber.org, jbenc@...hat.com,
	j.vimal@...il.com, soltys@....info, vapier@...too.org,
	jussi.kivilinna@...et.fi, kaber@...sh.net, jpirko@...hat.com,
	toke@...e.dk, dave.taht@...il.com, netdev@...r.kernel.org,
	bloat@...ts.bufferbloat.net, dan@...erfire.com, jg@...edesktop.org,
	cyrus@...nwrt.org, nbd@....name
Subject: Re: [PATCH] net_sched: htb: do not mix 1ns and 64ns time units

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 04 Jun 2013 10:11:48 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> commit 56b765b79 ("htb: improved accuracy at high rates") added another
> regression for low rates, because it mixes 1ns and 64ns time units.
> 
> So the maximum delay (mbuffer) was not 60 second, but 937 ms.
> 
> Lets convert all time fields to 1ns as 64bit arches are becoming the
> norm.
> 
> Reported-by: Jesper Dangaard Brouer <brouer@...hat.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html