netdev - Re: [Patch net-next v1 3/3] igmp: convert RTNL lock to a spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1370409719.2609.6.camel@cr0>
Date:	Wed, 05 Jun 2013 13:21:59 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net-next v1 3/3] igmp: convert RTNL lock to a spinlock

On Tue, 2013-06-04 at 20:52 -0700, Stephen Hemminger wrote:
> On Wed,  5 Jun 2013 11:33:31 +0800
> Cong Wang <amwang@...hat.com> wrote:
> 
> > From: Cong Wang <amwang@...hat.com>
> > 
> > It is not necessary to hold RTNL lock to protect mc_list,
> > at least IPv6 mcast is using a local spinlock, IPv4 can do
> > this too. This patch converts RTNL lock+RCU to spinlock+RCU,
> > so that vxlan does not need to release RTNL lock before
> > calling mcast API's.
> > 
> > Cc: Stephen Hemminger <stephen@...workplumber.org>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Signed-off-by: Cong Wang <amwang@...hat.com>
> 
> Not necessary, I have an alternate fix for vxlan.
> 

If you mean your _ip_mc_join_group() patch, I am sure it doesn't work.
Besides lack of lock_sock(), the locking order needs to be fixed too.
Trust me, I tried it, the _final_ patch is ugly.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html