netdev - Re: [Patch net-next v1 1/3] igmp: avoid taking RTNL for ip_mc_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1370409799.2609.7.camel@cr0>
Date:	Wed, 05 Jun 2013 13:23:19 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net-next v1 1/3] igmp: avoid taking RTNL for
 ip_mc_find_dev()

On Tue, 2013-06-04 at 21:07 -0700, Eric Dumazet wrote:
> On Wed, 2013-06-05 at 11:33 +0800, Cong Wang wrote:
> > +		rcu_read_lock();
> >  		imr->imr_ifindex = dev->ifindex;
> > -		idev = __in_dev_get_rtnl(dev);
> > +		idev = __in_dev_get_rcu(dev);
> > +		rcu_read_unlock();
> >  	}
> >  	return idev;
> >  }
> 
> 
> You must be kidding.
> 
> This is obviously wrong.
> 

Oops, rcu_read_lock should be taken for the whole life of 'idev'...

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html