[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 06 Jun 2013 16:05:04 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: sergei.shtylyov@...entembedded.com
Cc: netdev@...r.kernel.org, nobuhiro.iwamatsu.yj@...esas.com,
linux-sh@...r.kernel.org
Subject: Re: [PATCH v5 0/8] sh_eth: deal with #ifdef'fery
From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Thu, 6 Jun 2013 23:39:20 +0400
> This series of 8 patches are against Dave's 'net-next.git' repository.
> The series deals mostly with excess #ifdef'fery in the 'sh_eth' driver.
> It doesn't yet get rid of all the #ifdef'fery but that's a matter of another
> patchset. The last patch (it was almost in the middle of the series before),
> contrariwise, adds one missing #ifdef...
>
> [1/8] sh_eth: remove #ifdef around EDSR and GECMR bit definitions
> [2/8] sh_eth: use EDSR_ENALL to set EDSR
> [3/8] sh_eth: remove duplicate sh_eth_set_duplex() definitions
> [4/8] sh_eth: remove SH_ETH_HAS_TSU
> [5/8] sh_eth: add IRQ flags to 'struct sh_eth_cpu_data'
> [6/8] sh_eth: remove #ifdef around sh_eth_select_mii()
> [7/8] sh_eth: consolidate sh_eth_reset()
> [8/8] sh_eth: enclose PM code into #ifdef CONFIG_PM
All applied, thanks.
I think you should have two sets of const netdev_ops to cover the two
cases, instead of writing to a non-const netdev_ops. Could you send a
follow-on patch which does that?
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists