netdev - Re: [PATCH] xen-netback: don't de-reference vif pointer after having called xenvif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <51B7112B02000078000DD066@nat28.tlf.novell.com>
Date:	Tue, 11 Jun 2013 10:59:39 +0100
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	<ian.campbell@...rix.com>, <xen-devel@...ts.xen.org>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH] xen-netback: don't de-reference vif pointer after
 having called xenvif_put()

>>> On 11.06.13 at 11:01, David Miller <davem@...emloft.net> wrote:
> From: "Jan Beulich" <JBeulich@...e.com>
> Date: Wed, 05 Jun 2013 15:03:11 +0100
> 
>> When putting vif-s on the rx notify list, calling xenvif_put() must be
>> deferred until after the removal from the list and the issuing of the
>> notification, as both operations dereference the pointer.
>> 
>> Changing this got me to notice that the "irq" variable was effectively
>> unused (and was of too narrow type anyway).
>> 
>> Signed-off-by: Jan Beulich <jbeulich@...e.com>
> 
> You've included the commit message, and the patch, twice.  Once inline
> and once as an attachment, do not do this.  It makes the patch impossible
> to apply when I fetch it out of patchwork.
> 
> Please submit it properly.

Sending to multiple lists makes it impossible to match everyone's
preferences/requirements. xen-devel generally wants patches
inline and attached (for the case where the inline variant gets
mangled by mail programs).

I'll resend inline only, in the hope that it'll reach your inbox intact.

Jan

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html