netdev - Re: [PATCH net-next 2/4] openvswitch: Simplify interface ovs_flow_metadata_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALnjE+rX-RbMMMW3K=do4Lk+wNM8fx0yXqshbnUf-ShXxX2H1Q@mail.gmail.com>
Date:	Thu, 13 Jun 2013 09:13:22 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Jesse Gross <jesse@...ira.com>
Cc:	netdev <netdev@...r.kernel.org>,
	"dev@...nvswitch.org" <dev@...nvswitch.org>
Subject: Re: [PATCH net-next 2/4] openvswitch: Simplify interface ovs_flow_metadata_from_nlattrs()

On Wed, Jun 12, 2013 at 7:52 PM, Jesse Gross <jesse@...ira.com> wrote:
> On Wed, Jun 12, 2013 at 3:57 PM, Pravin B Shelar <pshelar@...ira.com> wrote:
>> diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c
>> index b15321a..150f181 100644
>> --- a/net/openvswitch/flow.c
>> +++ b/net/openvswitch/flow.c
>> @@ -1122,10 +1122,9 @@ int ovs_flow_from_nlattrs(struct sw_flow_key *swkey, int *key_lenp,
>>
>>  /**
>>   * ovs_flow_metadata_from_nlattrs - parses Netlink attributes into a flow key.
>> - * @priority: receives the skb priority
>> - * @mark: receives the skb mark
>> - * @in_port: receives the extracted input port.
>> - * @key: Netlink attribute holding nested %OVS_KEY_ATTR_* Netlink attribute
>> + * @flow: Receives extracted in_port, priority, tun_key and skb_mark.
>> + * @key_len: Length of key in @flow.  Used for calculating flow hash.
>> + * @attr: Netlink attribute holding nested %OVS_KEY_ATTR_* Netlink attribute
>>   * sequence.
>>   *
>>   * This parses a series of Netlink attributes that form a flow key, which must
>> @@ -1133,15 +1132,15 @@ int ovs_flow_from_nlattrs(struct sw_flow_key *swkey, int *key_lenp,
>>   * get the metadata, that is, the parts of the flow key that cannot be
>>   * extracted from the packet itself.
>>   */
>> -int ovs_flow_metadata_from_nlattrs(u32 *priority, u32 *mark, u16 *in_port,
>> -                              const struct nlattr *attr)
>> +int ovs_flow_metadata_from_nlattrs(struct sw_flow *flow, int key_len,
>> +                                  const struct nlattr *attr)
>
> It looks like key_len isn't actually used in this function. Is there
> another piece that you meant to include?

right, It is not required in this patch. will send updated patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html