netdev - Re: [ovs-dev] [PATCH net-next 4/4] openvswitch: make skb->csum consistent with rest of networking stack.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALnjE+q9vqPFqWz_S52ngA=H9EBJEj7xTPcA=efc3MdroJDTeQ@mail.gmail.com>
Date:	Thu, 13 Jun 2013 09:14:25 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Jesse Gross <jesse@...ira.com>
Cc:	netdev <netdev@...r.kernel.org>,
	"dev@...nvswitch.org" <dev@...nvswitch.org>
Subject: Re: [ovs-dev] [PATCH net-next 4/4] openvswitch: make skb->csum
 consistent with rest of networking stack.

On Wed, Jun 12, 2013 at 7:52 PM, Jesse Gross <jesse@...ira.com> wrote:
> On Wed, Jun 12, 2013 at 3:57 PM, Pravin B Shelar <pshelar@...ira.com> wrote:
>> diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
>> index 39cd821..e6ffb82 100644
>> --- a/net/openvswitch/datapath.c
>> +++ b/net/openvswitch/datapath.c
>> @@ -406,6 +406,7 @@ static int queue_userspace_packet(struct net *net, int dp_ifindex,
>>                 nskb = __vlan_put_tag(nskb, nskb->vlan_proto, vlan_tx_tag_get(nskb));
>>                 if (!nskb)
>>                         return -ENOMEM;
>> +               ovs_skb_postpush_rcsum(skb, skb->data + (2 * ETH_ALEN), VLAN_HLEN);
>
> This shouldn't be necessary since the packet is going to userspace,
> which won't use the skb->csum value.
ok, I will update patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html