netdev - Re: [PATCH] datapath: Add basic MPLS support to kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130613061651.GC15354@verge.net.au>
Date:	Thu, 13 Jun 2013 15:16:51 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Pravin Shelar <pshelar@...ira.com>
Cc:	Jesse Gross <jesse@...ira.com>,
	"dev@...nvswitch.org" <dev@...nvswitch.org>,
	netdev <netdev@...r.kernel.org>, Ravi K <rkerur@...il.com>,
	Isaku Yamahata <yamahata@...inux.co.jp>,
	Ben Pfaff <blp@...ira.com>,
	Jarno Rajahalme <jarno.rajahalme@....com>,
	Joe Stringer <joe@...d.net.nz>
Subject: Re: [PATCH] datapath: Add basic MPLS support to kernel

On Wed, Jun 12, 2013 at 11:00:56PM -0700, Pravin Shelar wrote:
> On Wed, Jun 12, 2013 at 6:19 PM, Simon Horman <horms@...ge.net.au> wrote:
> > On Wed, Jun 12, 2013 at 06:14:07PM -0700, Pravin Shelar wrote:
> >> On Tue, Jun 11, 2013 at 2:26 PM, Jesse Gross <jesse@...ira.com> wrote:
> >> > On Mon, Jun 10, 2013 at 1:07 AM, Simon Horman <horms@...ge.net.au> wrote:
> 
> >> >> @@ -341,10 +376,14 @@ static int netdev_send(struct vport *vport, struct sk_buff *skb)
> >> >>                                 nskb = skb->next;
> >> >>                                 skb->next = NULL;
> >> >>
> >> >> -                               skb = __vlan_put_tag(skb, vlan_tx_tag_get(skb));
> >> >> +                               if (vlan)
> >> >> +                                       skb = __vlan_put_tag(skb, vlan_tx_tag_get(skb));
> >> >>                                 if (likely(skb)) {
> >> >>                                         len += skb->len;
> >> >> -                                       vlan_set_tci(skb, 0);
> >> >> +                                       if (mpls)
> >> >> +                                               skb->protocol = mpls_protocol;
> >> >> +                                       if (vlan)
> >> >> +                                               vlan_set_tci(skb, 0);
> >> >>                                         dev_queue_xmit(skb);
> >> >>                                 }
> >> >
> >> > The order of setting the protocol field is different from the one
> >> > below and I think this one isn't right because it means that the MPLS
> >> > protocol can override the vlan.
> >> >
> >> > Pravin, can you take a look at this as well since you are working in
> >> > the same area?
> >>
> >> I think this compatibility code can be moved to new compat code posted
> >> on gre-restructuring code few changes.
> >
> > Sure that sounds reasonable but I am unsure of the status of those changes
> > and I would rather not rely on something that isn't ready to merge yet.
> 
> Right. sorry abt delay.
> But I think it is much closer now and it would be alot easy to handle
> compatibility, so it is worth waiting for.

Thanks. In that case we'll try to base the next version of this
patch on your patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html