netdev - Re: [PATCH] datapath: Add basic MPLS support to kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEP_g=8nU+K70onAcAw=ms7hHjC8TncRHSN6jMhrKfme5AQgdQ@mail.gmail.com>
Date:	Fri, 14 Jun 2013 12:51:24 -0700
From:	Jesse Gross <jesse@...ira.com>
To:	Simon Horman <horms@...ge.net.au>
Cc:	"dev@...nvswitch.org" <dev@...nvswitch.org>,
	netdev <netdev@...r.kernel.org>, Ravi K <rkerur@...il.com>,
	Isaku Yamahata <yamahata@...inux.co.jp>,
	Ben Pfaff <blp@...ira.com>,
	Jarno Rajahalme <jarno.rajahalme@....com>,
	Joe Stringer <joe@...d.net.nz>,
	Pravin Shelar <pshelar@...ira.com>
Subject: Re: [PATCH] datapath: Add basic MPLS support to kernel

On Tue, Jun 11, 2013 at 11:35 PM, Simon Horman <horms@...ge.net.au> wrote:
> On Tue, Jun 11, 2013 at 02:26:32PM -0700, Jesse Gross wrote:
>> When looking at this, I had an additional thought: different versions
>> of OpenFlow define the tag order differently and there is some limited
>> flexibility in how they get applied. Obviously, we're assuming that
>> vlans are applied before MPLS here. However, I'm not sure that is
>> actually required and may even simplify things (for example, your MPLS
>> GSO code doesn't do anything special with vlans and it should continue
>> to just work either way). I'm hesitant to suggest changes at this
>> point but it might actually make things cleaner and work with the
>> general model that we already have.
>
> Unsurprisingly I am also hesitant.
>
> I'm not sure that my readings of the specs leads to different valid
> orderings but if they are specified I am somewhat surprised.
>
> I believe that we could get bogged down in discussing various
> specifications without too much difficulty and at the risk of doing so I
> will explain my interpretation of Open Flow 1.3.2.
>
> Section 5.12 states:
>
> "Newly pushed tags should always be inserted as the outermost tag in the
> outermost valid location for that tag.".
>
> And RFC 3032 MPLS Label Stack Encoding states in section 2.1:
>
> "The label stack entries appear AFTER the data link layer headers, but
> BEFORE any network layer headers.".
>
> My reading is that the only valid location for an MPLS LSE to be pushed
> is after the L2 header including any VLAN tags that may be present. And
> that the only valid place to push any VLAN tags is after the L2 header,
> that is, before the MPLS label stack if it is present.
>
> Of course there may be other relevant RFCs that I have not examined.

My goal is also to avoid getting bogged down in various specs and
RFCs, which to some extent being flexible actually helps to avoid. The
specific scenario that triggered this thought is QinQ: since it
typically uses a different EtherType, which we don't support at the
moment, we would push the MPLS header before the vlan. However, if we
added support for QinQ then we would start push the MPLS header, which
seems an undesirable change.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html