netdev - Re: [PATCH] net: ethernet: stmicro: stmmac: Fix compile error when STMMAC_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130613.013152.180392586047160961.davem@davemloft.net>
Date:	Thu, 13 Jun 2013 01:31:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dinguyen@...era.com
Cc:	netdev@...r.kernel.org, dinh.linux@...il.com,
	peppe.cavallaro@...com
Subject: Re: [PATCH] net: ethernet: stmicro: stmmac: Fix compile error when
 STMMAC_XMIT_DEBUG used

From: <dinguyen@...era.com>
Date: Wed, 12 Jun 2013 11:05:03 -0500

> From: Dinh Nguyen <dinguyen@...era.com>
> 
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function:
> stmmac_xmit drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1902:74:
> error: expected ) before __func__
> 
> Signed-off-by: Dinh Nguyen <dinguyen@...era.com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>
> CC: David S. Miller <davem@...emloft.net>

Applied, but this debugging mechanism is completely unacceptable.

We have a dynamic, run time, way to do stuff like this without
peppering up a driver with gross ifdefs.

This driver must be converted over to use "netif_msg_*()" et al.
to guard message logging of different types of events.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html