| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <51B99751.6050006@st.com> Date: Thu, 13 Jun 2013 11:56:33 +0200 From: Giuseppe CAVALLARO <peppe.cavallaro@...com> To: David Miller <davem@...emloft.net> Cc: dinguyen@...era.com, netdev@...r.kernel.org, dinh.linux@...il.com Subject: Re: [PATCH] net: ethernet: stmicro: stmmac: Fix compile error when STMMAC_XMIT_DEBUG used Hello David On 6/13/2013 10:31 AM, David Miller wrote: > From: <dinguyen@...era.com> > Date: Wed, 12 Jun 2013 11:05:03 -0500 > >> From: Dinh Nguyen <dinguyen@...era.com> >> >> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function: >> stmmac_xmit drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1902:74: >> error: expected ) before __func__ >> >> Signed-off-by: Dinh Nguyen <dinguyen@...era.com> >> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com> >> CC: David S. Miller <davem@...emloft.net> > > Applied, but this debugging mechanism is completely unacceptable. I agree with you, I do not like it too this debug code is quite old and fixed to the initial driver version. I had used it to the initial debug so I must rework it (also because debug has to be guarantee w/o errors and w/o ifdef proliferation) I'll prepare a patch asap. Peppe > > We have a dynamic, run time, way to do stuff like this without > peppering up a driver with gross ifdefs. > > This driver must be converted over to use "netif_msg_*()" et al. > to guard message logging of different types of events. > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists