netdev - Re: [PATCH net] packet: packet_getname_spkt: make sure string is always 0-terminated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130613.013859.1357765580190105873.davem@davemloft.net>
Date:	Thu, 13 Jun 2013 01:38:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dborkman@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] packet: packet_getname_spkt: make sure string is
 always 0-terminated

From: Daniel Borkmann <dborkman@...hat.com>
Date: Wed, 12 Jun 2013 16:02:27 +0200

> uaddr->sa_data is exactly of size 14, which is hard-coded here and
> passed as a size argument to strncpy(). A device name can be of size
> IFNAMSIZ (== 16), meaning we might leave the destination string
> unterminated. Thus, use strlcpy() and also sizeof() while we're
> at it. We need to memset the data area beforehand, since strlcpy
> does not padd the remaining buffer with zeroes for user space, so
> that we do not possibly leak anything.
> 
> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>

Applied, and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html