netdev - Re: [PATCH net-next] bcm63xx_enet: add support Broadcom BCM6345 Ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130613.014450.1434692343011842828.davem@davemloft.net>
Date:	Thu, 13 Jun 2013 01:44:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	florian@...nwrt.org
Cc:	netdev@...r.kernel.org, ralf@...ux-mips.org, blogic@...nwrt.org,
	linux-mips@...ux-mips.org, mbizon@...ebox.fr, jogo@...nwrt.org,
	cernekee@...il.com
Subject: Re: [PATCH net-next] bcm63xx_enet: add support Broadcom BCM6345
 Ethernet

From: Florian Fainelli <florian@...nwrt.org>
Date: Wed, 12 Jun 2013 20:53:05 +0100

> +#ifdef BCMCPU_RUNTIME_DETECT

I want the MIPS folks to fix this brain damange.

This runtime detect thing is just a big mess in a header file
using hundreds of lines of CPP stuff to express what is fundamentally
a simple (albeit sizable) Kconfig dependency.

And this ifdef virus spreads from that header file now into this
driver.

How can it possibly make sense to have this "maybe it's static at
build time, maybe it's dynamic" coded into every single piece of code
for platform drivers or any other thing related to this set of MIPSs
cpus?

It's rediculous, and I refuse to add code to my tree which continues
this trend, sorry.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html