netdev - Re: [Patch net-next v2] tcp: introduce a per-route knob for quick ack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1371113157.10194.14.camel@cr0>
Date:	Thu, 13 Jun 2013 16:45:57 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, Rick Jones <rick.jones2@...com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	"David S. Miller" <davem@...emloft.net>,
	Thomas Graf <tgraf@...g.ch>,
	David Laight <David.Laight@...LAB.COM>
Subject: Re: [Patch net-next v2] tcp: introduce a per-route knob for quick
 ack

On Wed, 2013-06-12 at 23:42 -0700, Eric Dumazet wrote:
> On Thu, 2013-06-13 at 14:24 +0800, Cong Wang wrote:
> > diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> > index ec335fa..f840b92 100644
> > --- a/net/ipv4/tcp_output.c
> > +++ b/net/ipv4/tcp_output.c
> > @@ -160,6 +160,7 @@ static void tcp_event_data_sent(struct tcp_sock *tp,
> >  {
> >  	struct inet_connection_sock *icsk = inet_csk(sk);
> >  	const u32 now = tcp_time_stamp;
> > +	const struct dst_entry *dst = __sk_dst_get(sk);
> >  
> 
> 
> Same here : Are you sure dst cannot be NULL ?
> 

No, I missed the check for some reason... Will fix it.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html