netdev - Re: [ovs-dev] [PATCH net-next 09/12] openvswitch: Add tunneling interface.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALnjE+oQSJA2Bd_yBSy2WXAdauS4_ey98qpMOcSpJ9Wc7qnjSQ@mail.gmail.com>
Date:	Fri, 14 Jun 2013 19:17:37 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Jesse Gross <jesse@...ira.com>
Cc:	netdev <netdev@...r.kernel.org>,
	"dev@...nvswitch.org" <dev@...nvswitch.org>
Subject: Re: [ovs-dev] [PATCH net-next 09/12] openvswitch: Add tunneling interface.

On Fri, Jun 14, 2013 at 5:23 PM, Jesse Gross <jesse@...ira.com> wrote:
> On Thu, Jun 13, 2013 at 11:24 AM, Pravin B Shelar <pshelar@...ira.com> wrote:
>> diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c
>> index fba57a0..575c0bd 100644
>> --- a/net/openvswitch/flow.c
>> +++ b/net/openvswitch/flow.c
>>  static int ipv4_flow_from_nlattrs(struct sw_flow_key *swkey, int *key_len,
>> @@ -938,14 +942,14 @@ static int parse_flow_nlattrs(const struct nlattr *attr,
>>                 u16 type = nla_type(nla);
>>                 int expected_len;
>>
>> -               if (type > OVS_KEY_ATTR_MAX || attrs & (1 << type))
>> +               if (type > OVS_KEY_ATTR_MAX || attrs & (1ULL << type))
>
> The use of 1ULL (64-bit flags) is from the old compatibility code so
> it's not needed anymore.
>
ok.
>> +int ipv4_tun_from_nlattr(const struct nlattr *attr,
>> +                        struct ovs_key_ipv4_tunnel *tun_key)
>
> We should prefix these function names with ovs_.

ok. I will update patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html