netdev - Re: [ovs-dev] [PATCH net-next 09/12] openvswitch: Add tunneling interface.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEP_g=_rcJtfDYxt9cENZDHaiv9D0pRbobsr7Aw9sHNeM6BMkw@mail.gmail.com>
Date:	Fri, 14 Jun 2013 17:23:29 -0700
From:	Jesse Gross <jesse@...ira.com>
To:	Pravin B Shelar <pshelar@...ira.com>
Cc:	netdev <netdev@...r.kernel.org>,
	"dev@...nvswitch.org" <dev@...nvswitch.org>
Subject: Re: [ovs-dev] [PATCH net-next 09/12] openvswitch: Add tunneling interface.

On Thu, Jun 13, 2013 at 11:24 AM, Pravin B Shelar <pshelar@...ira.com> wrote:
> diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c
> index fba57a0..575c0bd 100644
> --- a/net/openvswitch/flow.c
> +++ b/net/openvswitch/flow.c
>  static int ipv4_flow_from_nlattrs(struct sw_flow_key *swkey, int *key_len,
> @@ -938,14 +942,14 @@ static int parse_flow_nlattrs(const struct nlattr *attr,
>                 u16 type = nla_type(nla);
>                 int expected_len;
>
> -               if (type > OVS_KEY_ATTR_MAX || attrs & (1 << type))
> +               if (type > OVS_KEY_ATTR_MAX || attrs & (1ULL << type))

The use of 1ULL (64-bit flags) is from the old compatibility code so
it's not needed anymore.

> +int ipv4_tun_from_nlattr(const struct nlattr *attr,
> +                        struct ovs_key_ipv4_tunnel *tun_key)

We should prefix these function names with ovs_.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html