netdev - Re: [PATCH net-next 3/5] mv643xx_eth.c: convert skb->end into skb_end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130617.171320.2300960990080770267.davem@davemloft.net>
Date:	Mon, 17 Jun 2013 17:13:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	horms@...ge.net.au
Cc:	yamahata@...inux.co.jp, netdev@...r.kernel.org,
	buytenh@...tstofly.org
Subject: Re: [PATCH net-next 3/5] mv643xx_eth.c: convert skb->end into
 skb_end_poitner(skb)

From: Simon Horman <horms@...ge.net.au>
Date: Mon, 17 Jun 2013 11:02:18 +0900

> On Fri, Jun 14, 2013 at 05:58:33PM +0900, Isaku Yamahata wrote:
>> The change set of 4305b541 "[SK_BUFF]: Convert skb->end to sk_buff_data_t"
>> converted skb->end from pointer to sk_buff_data_t.
>> The pointed value should be accessed via skb_end_pointer().
>> 
>> Since arm or ppc arch doesn't define NET_SKBUFF_DATA_USES_OFFSET,
>> skb->end is effectively pointer. So it doesn't cause a real problem.
>> But this patch is good for consistency.
>> 
>> Found by inspection. Compile test only.
>> 
>> Cc: Simon Horman <horms@...ge.net.au>
>> Cc: Lennert Buytenhek <buytenh@...tstofly.org>
>> Signed-off-by: Isaku Yamahata <yamahata@...inux.co.jp>
> 
> Reviewed-by: Simon Horman <horms@...ge.net.au>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html