lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 17 Jun 2013 17:13:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	horms@...ge.net.au
Cc:	yamahata@...inux.co.jp, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 4/5] pxa168_eth: convert skb->end into
 skb_end_pointer(skb)

From: Simon Horman <horms@...ge.net.au>
Date: Mon, 17 Jun 2013 11:01:50 +0900

> On Fri, Jun 14, 2013 at 05:58:34PM +0900, Isaku Yamahata wrote:
>> The change set of 4305b541, "[SK_BUFF]: Convert skb->end to sk_buff_data_t"
>> converted skb->end from pointer type to sk_buff_data_t.
>> The pointed value should be accessed via skb_end_pointer().
>> 
>> Since arm arch doesn't define NET_SKBUFF_DATA_USES_OFFSET,
>> skb->end is effectively pointer. So it doesn't cause a real problem.
>> But this patch is good for consistency.
>> 
>> Found by inspection. Compile tested only.
>> 
>> Cc: Simon Horman <horms@...ge.net.au>
>> Signed-off-by: Isaku Yamahata <yamahata@...inux.co.jp>
> 
> Reviewed-by: Simon Horman <horms@...ge.net.au>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists