lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 21 Jun 2013 10:10:09 -0700 From: Joe Perches <joe@...ches.com> To: Jitendra Kalsaria <jitendra.kalsaria@...gic.com> Cc: davem@...emloft.net, netdev@...r.kernel.org, sony.chacko@...gic.com, shahed.shaikh@...gic.com, Dept_NX_Linux_NIC_Driver@...gic.com Subject: Re: [PATCH net-next 2/8] qlcnic: Secondary unicast MAC address support. On Fri, 2013-06-21 at 12:30 -0400, Jitendra Kalsaria wrote: > From: Jitendra Kalsaria <jitendra.kalsaria@...gic.com> > > Add support for configuring secondary unicast address which > will use existing HW filters to store all the unicast MAC > addresses and prevent device going into promiscuous mode. [] > diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h [] > @@ -421,6 +421,7 @@ struct qlcnic_hardware_context { > + u8 max_uc_count; > diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h [] > +#define QLC_83XX_MAX_UC_COUNT 4096 > diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hdr.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hdr.h [] > +#define QLCNIC_MAX_UC_COUNT 512 These #defines don't seem right. There's no way to fit these values in a u8. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists