netdev - Re: [PATCH net-next 2/8] qlcnic: Secondary unicast MAC address support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BECD8E8A1B550B48A1BF97C13991F60E33FD33@avmb2.qlogic.org>
Date:	Fri, 21 Jun 2013 17:45:53 +0000
From:	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
To:	Joe Perches <joe@...ches.com>
CC:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Sony Chacko <sony.chacko@...gic.com>,
	Shahed Shaikh <shahed.shaikh@...gic.com>,
	Dept-NX Linux NIC Driver 
	<Dept_NX_Linux_NIC_Driver@...gic.com>
Subject: Re: [PATCH net-next 2/8] qlcnic: Secondary unicast MAC address
 support.

On 6/21/13 10:10 AM, "Joe Perches" <joe@...ches.com> wrote:

>On Fri, 2013-06-21 at 12:30 -0400, Jitendra Kalsaria wrote:
>> From: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
>> 
>> Add support for configuring secondary unicast address which
>> will use existing HW filters to store all the unicast MAC
>> addresses and prevent device going into promiscuous mode.
>
>[]
>
>> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
>>b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
>[]
>> @@ -421,6 +421,7 @@ struct qlcnic_hardware_context {
>> +	u8 max_uc_count;
>
>> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h
>>b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h
>[]
>> +#define QLC_83XX_MAX_UC_COUNT			4096
>
>> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hdr.h
>>b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_hdr.h
>[]
>> +#define QLCNIC_MAX_UC_COUNT		512
>
>These #defines don't seem right.
>There's no way to fit these values in a u8.

Thanks for pointing it, I will fix it and resubmit these series again.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html