netdev - Re: [PATCH 1/2] sh_eth: define/use EESR_RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51D17D0D.7040701@cogentembedded.com>
Date:	Mon, 01 Jul 2013 16:58:53 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Magnus Damm <magnus.damm@...il.com>
CC:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>,
	SH-Linux <linux-sh@...r.kernel.org>
Subject: Re: [PATCH 1/2] sh_eth: define/use EESR_RX_CHECK macro

Hello.

On 01-07-2013 16:12, Magnus Damm wrote:

>>>>> sh_eth_interrupt() uses the same Rx interrupt mask twice to check the
>>>>> interrupt
>>>>> status register -- #define EESR_RX_CHECK  and use it instead.

>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

>>>> Thanks for the patch, nice to see that this driver is moving forward.

>>     Magnus, BTW, are you content with the amount of cleanup that is currently
>> queued in the Dave Miller's 'net-next.git' repo, or should I move further:
>> e.g., move the SoC specific fields like 'register_type' from the platform
>> data to the driver's internal data structure?

> I just had a look at this particular driver in net-next.git and I
> think it looks very good. Thanks a lot for your efforts!

> Regarding moving further with cleanups, it looks to me that it is now
> possible to build a single kernel image with this driver included and
> use it on multiple SoCs without #ifdef causing trouble. This recent
> development has been needed for mach-shmobile to play well with the
> multiplatform work going on in the ARM architecture. So since that
> seems solved then I'm quite happy with the driver state from a
> cleanliness point of view.

> As for this driver in general, I'd be very happy to see future
> development in these areas:
> - DT support

    Full DT support won't be possible due to the driver using procedural 
platform data. Partial support will be possible using OF_DEV_AUXDATA() 
to assign the platform data to a device.

> - PHY support for r8a7790 Lager

    Simon seems to be working on this. AFAIK, we don't yet have R8A7790 
based board in our inventory (neither the board manual).

 > - PHY IRQ support for r8a7790 Lager

> Let me know if I can help you with remote board access.

    Yes, you can.

> Cheers,

> / magnus

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html