lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 9 Jul 2013 08:43:14 +0300 (EEST) From: Julian Anastasov <ja@....bg> To: Shmulik Ladkani <shmulik.ladkani@...il.com> cc: "David S. Miller" <davem@...emloft.net>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, netdev@...r.kernel.org, eyal.birger@...il.com Subject: Re: net/ipv4/route.c: Routing anomaly introduced by 89aef89 (ipv4: Delete routing cache.) Hello, On Mon, 8 Jul 2013, Shmulik Ladkani wrote: > Hi, > > In 89aef89 (ipv4: Delete routing cache) the following was removed from > ip_route_input_common (nowadays named ip_route_input_noref): > > - tos &= IPTOS_RT_MASK; > > As a side effect, the 'tos' argument passed to 'ip_route_input_slow' is > the "raw" u8, as present in iph->tos (opposed to the formerly "masked" > value). > > This may affect the route calculation, as this value is later placed in > fl4.flowi4_tos for matching purposes (using equality to the tos stored > in the FIB Rule and/or Route). > > (BTW, the question whether applying the historical IPTOS_RT_MASK > prior route lookup is interesting on its own...) > > However, 89aef89 created an anomaly - since in the output path, routing > *still* uses the IPTOS_RT_MASK (see __ip_route_output_key for example). > > It seems the omission of 'tos &= IPTOS_RT_MASK' from > 'ip_route_input_noref' was accidental. Agreed > We should align input/output behavior by reverting the omission, or > alternatively we may reconsider the entire IPTOS_RT_MASK thing. The right thing should be to use tos &= IPTOS_RT_MASK at beginning of ip_route_input_noref. Regards -- Julian Anastasov <ja@....bg> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists