netdev - Re: net/ipv4/route.c: Routing anomaly introduced by 89aef89 (ipv4: Delete routing cache.)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130709122802.34831221@pixies.home.jungo.com>
Date:	Tue, 9 Jul 2013 12:28:02 +0300
From:	Shmulik Ladkani <shmulik.ladkani@...il.com>
To:	Julian Anastasov <ja@....bg>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	netdev@...r.kernel.org, eyal.birger@...il.com
Subject: Re: net/ipv4/route.c: Routing anomaly introduced by 89aef89 (ipv4:
 Delete routing cache.)

On Tue, 9 Jul 2013 08:43:14 +0300 (EEST) Julian Anastasov <ja@....bg> wrote:
> > It seems the omission of 'tos &= IPTOS_RT_MASK' from
> > 'ip_route_input_noref' was accidental.
> 
> 	Agreed
> 
> > We should align input/output behavior by reverting the omission, or
> > alternatively we may reconsider the entire IPTOS_RT_MASK thing.
> 
> 	The right thing should be to use tos &= IPTOS_RT_MASK
> at beginning of ip_route_input_noref.

Agreed. Will post a patch.

Regards,
Shmulik
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html