netdev - Re: [PATCH net RESEND v2] ipv6: fix route selection if kernel is not compiled with CONFIG_IPV6_ROUTER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130711101534.GA5207@order.stressinduktion.org>
Date:	Thu, 11 Jul 2013 12:15:34 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, petrus.lt@...il.com,
	yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net RESEND v2] ipv6: fix route selection if kernel is not compiled with CONFIG_IPV6_ROUTER_PREF

On Wed, Jul 10, 2013 at 05:36:33PM -0700, David Miller wrote:
> From: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Date: Wed, 10 Jul 2013 23:00:12 +0200
> 
> > I changed the return value of rt6_check_neigh to:
> >    1 in case of the dst entry validated
> >   -1 in case of we had no dst_entry and we need to do rr now
> >   -2 in case a we had a dst_entry and it did not validate
> 
> Please, at the very least, create an enumeration for this set of
> possible return values.

Yes, this should have caught my eyes earlier.

> Although I don't like how that RR boolean is passed around by
> reference, I can't suggest anything better so I won't require
> you to get rid of that.

I fear so, too. I also tought about marking the soft-fail state in the
pointer or adding a rt6_match structure. But both seem more complex to me.

Will send an updated patch shortly.

Thanks,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html